Open
Conversation
Contributor
Author
|
Want to remove some debugging stuff before review but only after I make sure it actually passes CI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new build target to the fuzzer package,
build:dev, which will build the fuzzer with a debug configuration. It also renames theprebuildtarget toprepackbecauseprebuildwill run prior tobuildwhich means that the call toprebuildwill result in the cmake call inbuildseeing that things are already built and not doing anything.While this could be handled by a
prebuild:devscript that doesn't use--strip, the other problem is thatprebuild(the binary, not the script), will look to see if its output tarball already exists and refuses to continue if all you've changed is the build config and no actual code. That's why I chose to have more of this process go throughbuildand leftprebuildto be part of ourprereleasepipeline.